Skip to content

Param Revamp - CMD #1728

Merged
tbhallett merged 19 commits intomasterfrom
1649-cmd
Dec 9, 2025
Merged

Param Revamp - CMD #1728
tbhallett merged 19 commits intomasterfrom
1649-cmd

Conversation

@mmsuarezcosta
Copy link
Collaborator

@mmsuarezcosta mmsuarezcosta commented Oct 14, 2025

Files

  • Note: There are many subfolders with parameters defined per condition. Given that CMD is quite unique in that it has multiple diseases in one module, I believe it may be best to keep this structure as-is for now. One day when we decide to refactor and create modules by disease (e.g. one specific to hypertension, diabetes, ...) then that may be the best time to refactor the parameter files. Thoughts? @marghe-molaro @mnjowe
  • Deleted folders and sub-files that were not in use in the module:
    • ResourceFile_cd_condition_and_events_incidence
    • ResourceFile_cd_condition_incidence
    • ResourceFile_cd_event_incidence
    • ResourceFile_cd_event_prevalence

Parameters to review (documented by folder)

Folder: ResourceFile_cmd_condition_death & ResourceFile_cmd_condition_onset & ResourceFile_cmd_condition_removal

  • Most rr marked as universal except the following which I believe to have local basis:
    • rr of urbanicity & wealth
    • rr of marital status, education, sanitation, wood burning stove
    • rr depression

Folder: ResourceFile_cmd_condition_hsi

  • pr_treatment_works: marked as local because believe it takes into account other factors beyond medication

Folder: ResourceFile_cmd_condition_prevalence

  • Have min and max values documented. I am labeling the prior_note as 'CI'. Have not gone into the documentation to determine exactly what the prior min and max are references to

Folder: ResourceFile_cmd_condition_prevalence

  • File hypertension.csv is empty

Folder: ResourceFile_cmd_condition_prevalence

  • Only has file hypertension.csv

Remain hardcoded

  • All medical consumables and dosages

Analysis Scripts

Checked to run analysis files before and after modifications. The file cardiometabolicdisorders_plots.py has the error ZeroDivisionError: division by zero

@mmsuarezcosta mmsuarezcosta linked an issue Oct 14, 2025 that may be closed by this pull request
@mmsuarezcosta mmsuarezcosta marked this pull request as ready for review October 15, 2025 15:08
@mmsuarezcosta
Copy link
Collaborator Author

@marghe-molaro ready for review

@marghe-molaro
Copy link
Collaborator

I'm happy with this, I believe this is ready for @tbhallett to review as acting module load

@tbhallett
Copy link
Collaborator

tbhallett commented Nov 28, 2025

The parameter changes on this seem fine.

But the refactoring has caused problems in running the key calibration file: src/scripts/cardio_metabolic_disorders_analyses/cardiometabolicdisorders_plots.py

UPDATE: NOW RESOLVED

UPDATE: AND FIDDLY MERGE WITH NEW CKD PARAMETERS THAT CAME INTO MASTER BEFORE THIS -- ALSO DONE.

@tbhallett tbhallett merged commit c2cc5b6 into master Dec 9, 2025
63 of 65 checks passed
@tbhallett tbhallett deleted the 1649-cmd branch December 9, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMD Module

3 participants

Comments