Conversation
Closed
Collaborator
Author
|
@marghe-molaro ready for review |
Collaborator
|
I'm happy with this, I believe this is ready for @tbhallett to review as acting module load |
Collaborator
|
The parameter changes on this seem fine. But the refactoring has caused problems in running the key calibration file: UPDATE: NOW RESOLVED UPDATE: AND FIDDLY MERGE WITH NEW CKD PARAMETERS THAT CAME INTO MASTER BEFORE THIS -- ALSO DONE. |
also mixed up upper and lower gbd columns
# Conflicts: # resources/cmd/ResourceFile_cmd_condition_hsi/chronic_kidney_disease.csv # resources/cmd/ResourceFile_cmd_condition_hsi/diabetes.csv # resources/cmd/ResourceFile_cmd_parameters.csv # src/tlo/methods/cardio_metabolic_disorders.py
tbhallett
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files
Parameters to review (documented by folder)
Folder: ResourceFile_cmd_condition_death & ResourceFile_cmd_condition_onset & ResourceFile_cmd_condition_removal
Folder: ResourceFile_cmd_condition_hsi
pr_treatment_works: marked as local because believe it takes into account other factors beyond medicationFolder: ResourceFile_cmd_condition_prevalence
Folder: ResourceFile_cmd_condition_prevalence
Folder: ResourceFile_cmd_condition_prevalence
Remain hardcoded
Analysis Scripts
Checked to run analysis files before and after modifications. The file cardiometabolicdisorders_plots.py has the error
ZeroDivisionError: division by zero